linux-kernel - [tip:locking/core] locking/rwsem, fs: Use killable down_read() in iterate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 04:05:55 -0700
From:   tip-bot for Kirill Tkhai <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, hpa@...or.com, peterz@...radead.org,
        tglx@...utronix.de, torvalds@...ux-foundation.org,
        ktkhai@...tuozzo.com, linux-kernel@...r.kernel.org
Subject: [tip:locking/core] locking/rwsem, fs: Use killable down_read() in
 iterate_dir()

Commit-ID:  0dc208b5d5feedc795cbf124539decd182c8e99e
Gitweb:     https://git.kernel.org/tip/0dc208b5d5feedc795cbf124539decd182c8e99e
Author:     Kirill Tkhai <ktkhai@...tuozzo.com>
AuthorDate: Fri, 29 Sep 2017 19:06:48 +0300
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 10 Oct 2017 11:50:16 +0200

locking/rwsem, fs: Use killable down_read() in iterate_dir()

There was mutex_lock_interruptible() initially, and it was changed
to rwsem, but there were not killable rwsem primitives that time.
>>From commit 9902af79c01a:

    "The main issue is the lack of down_write_killable(), so the places
     like readdir.c switched to plain inode_lock(); once killable
     variants of rwsem primitives appear, that'll be dealt with"

Use down_read_killable() same as down_write_killable() in !shared
case, as concurrent inode_lock() may take much time, that may be
wanted to be interrupted by user.

Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: arnd@...db.de
Cc: avagin@...tuozzo.com
Cc: davem@...emloft.net
Cc: fenghua.yu@...el.com
Cc: gorcunov@...tuozzo.com
Cc: heiko.carstens@...ibm.com
Cc: hpa@...or.com
Cc: ink@...assic.park.msu.ru
Cc: mattst88@...il.com
Cc: rientjes@...gle.com
Cc: rth@...ddle.net
Cc: schwidefsky@...ibm.com
Cc: tony.luck@...el.com
Cc: viro@...iv.linux.org.uk
Link: http://lkml.kernel.org/r/150670120820.23930.5455667921545937220.stgit@localhost.localdomain
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 fs/readdir.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/fs/readdir.c b/fs/readdir.c
index 8965954..7c584bb 100644
--- a/fs/readdir.c
+++ b/fs/readdir.c
@@ -36,13 +36,12 @@ int iterate_dir(struct file *file, struct dir_context *ctx)
 	if (res)
 		goto out;
 
-	if (shared) {
-		inode_lock_shared(inode);
-	} else {
+	if (shared)
+		res = down_read_killable(&inode->i_rwsem);
+	else
 		res = down_write_killable(&inode->i_rwsem);
-		if (res)
-			goto out;
-	}
+	if (res)
+		goto out;
 
 	res = -ENOENT;
 	if (!IS_DEADDIR(inode)) {