linux-kernel - Re: [PATCH] media: imon: Fix null-ptr-deref in imon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 13:26:54 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sean Young <sean@...s.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Andi Shyti <andi.shyti@...sung.com>,
        Arnd Bergmann <arnd@...db.de>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: [PATCH] media: imon: Fix null-ptr-deref in imon_probe

On Mon, Oct 9, 2017 at 8:14 PM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> It seems that the return value of usb_ifnum_to_if() can be NULL and
> needs to be checked.

Hi Arvind,

Your patch fixes the issue.

Thanks!

Tested-by: Andrey Konovalov <andreyknvl@...gle.com>

>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> This bug report by Andrey Konovalov usb/media/imon: null-ptr-deref
> in imon_probe
>
>  drivers/media/rc/imon.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
> index 7b3f31c..0c46155 100644
> --- a/drivers/media/rc/imon.c
> +++ b/drivers/media/rc/imon.c
> @@ -2517,6 +2517,11 @@ static int imon_probe(struct usb_interface *interface,
>         mutex_lock(&driver_lock);
>
>         first_if = usb_ifnum_to_if(usbdev, 0);
> +       if (!first_if) {
> +               ret = -ENODEV;
> +               goto fail;
> +       }
> +
>         first_if_ctx = usb_get_intfdata(first_if);
>
>         if (ifnum == 0) {
> --
> 2.7.4
>