linux-kernel - Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 15:59:20 +0200
From:   Greg KH <greg@...ah.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        pali.rohar@...il.com, rjw@...ysocki.net, mjg59@...gle.com,
        hch@....de
Subject: Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce
 userspace interface

On Mon, Oct 09, 2017 at 05:51:52PM -0500, Mario Limonciello wrote:
> +	ret = device_create_file(&wdev->dev, &priv->req_buf_size_attr);
> +	if (ret)
> +		goto fail_create_sysfs;

Why isn't the "WMI core" creating this sysfs file?  Why have per-driver
sysfs files, making all of the different apis totally different?  It's a
"common" attribute that they are all going to have to provide, right?

That way you also don't race with userspace :)

thanks,

greg k-h