linux-kernel - Re: [PATCH V2] writeback: merge try_to_writeback_inodes_sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 08:15:02 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Rakesh Pandit <rakesh@...era.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jan Kara <jack@...e.cz>, linux-block@...r.kernel.org
Subject: Re: [PATCH V2] writeback: merge try_to_writeback_inodes_sb_nr() into
 caller

On 10/10/2017 03:43 AM, Rakesh Pandit wrote:
> Hi Jens,
> 
> On Mon, Oct 09, 2017 at 02:00:29PM +0200, Jan Kara wrote:
>> On Mon 09-10-17 13:34:41, Rakesh Pandit wrote:
>>> Since commit 925a6efb8ff0c ("Btrfs: stop using
>>> try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't
>>> been used outside so stop exporting it.
>>>
>>> In addition we merge it into try_to_writeback_inodes_sb() which is the
>>> only caller.  Also change return type of try_to_writeback_inodes_sb to
>>> void as the only user ext4 doesn't care.
>>>
>>> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
>>
>> Looks good. You can add:
>>
>> Reviewed-by: Jan Kara <jack@...e.cz>
>>
>> 								Honza
> 
> As there are many writeback related changes on your tree would you be
> okay queuing this up as well for-4.15 with above reviewed-by tag ?
> 
> This should apply fine on your tree for-4.15.
> 
> Let me know if that isn't okay.

That's fine, I'll queue it up.

-- 
Jens Axboe