linux-kernel - [PATCH 1/1] [mm]: cma: change pr_info to pr_err for cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 11:50:33 -0400
From:   Pintu Agarwal <pintu.ping@...il.com>
To:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, labbott@...hat.com,
        gregkh@...uxfoundation.org, jaewon31.kim@...sung.com,
        opendmb@...il.com, pintu.ping@...il.com
Subject: [PATCH 1/1] [mm]: cma: change pr_info to pr_err for cma_alloc fail log

It was observed that under cma_alloc fail log, pr_info was
used instead of pr_err.
This will lead to problem if printk debug level is set to
below 7. In this case the cma_alloc failure log will not
be captured in the log and it will be difficult to debug.

Simply replace the pr_info with pr_err to capture failure log.

Signed-off-by: Pintu Agarwal <pintu.ping@...il.com>
---
 mm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.c b/mm/cma.c
index c0da318..e0d1393 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -461,7 +461,7 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
 	trace_cma_alloc(pfn, page, count, align);
 
 	if (ret) {
-		pr_info("%s: alloc failed, req-size: %zu pages, ret: %d\n",
+		pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n",
 			__func__, count, ret);
 		cma_debug_show_areas(cma);
 	}
-- 
2.7.4