[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 10 Oct 2017 09:05:23 -0700
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org,
mingo@...nel.org, torvalds@...ux-foundation.org,
mark.rutland@....com, linux-arch@...r.kernel.org,
will.deacon@....com, Jonathan Corbet <corbet@....net>,
Alexander Kuleshov <kuleshovmail@...il.com>
Subject: Re: [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove
smp_read_barrier_depends()
On Tue, Oct 10, 2017 at 05:54:51PM +0200, Peter Zijlstra wrote:
> On Tue, Oct 10, 2017 at 08:50:42AM -0700, Paul E. McKenney wrote:
> > + /* We need a barrier between the read of the pointer,
> > + * which is supplied by the above READ_ONCE().
> > */
>
> > /* We need a barrier between the read of the pointer
> > * and dereferencing the pointer - but only if we are
> > * actually going to dereference it.
> > */
>
> Could you also fix those "disgusting drug-induced crap" comment styles
> while you're there anyway?
>
> http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html
If Dave is OK with it, I will do so on my next pass.
Thanx, Paul
Powered by blists - more mailing lists