[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 10 Oct 2017 21:17:17 +0200
From: Radim Krčmář <rkrcmar@...hat.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
suravee.suthikulpanit@....com
Subject: Re: [PATCH] KVM: SVM: unconditionally wake up VCPU on IOMMU interrupt
2017-10-10 12:57+0200, Paolo Bonzini:
> Checking the mode is unnecessary, and is done without a memory barrier
> separating the LAPIC write from the vcpu->mode read; in addition,
> kvm_vcpu_wake_up is already doing a check for waiters on the wait queue
> that has the same effect.
>
> In practice it's safe because spin_lock has full-barrier semantics on x86,
> but don't be too clever.
>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
Reviewed-by: Radim Krčmář <rkrcmar@...hat.com>
Powered by blists - more mailing lists