linux-kernel - Re: [PATCH] Fix mpage_writepage() for pages with buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 12:44:21 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        linux-fsdevel@...r.kernel.org, linux-nvdimm@...ts.01.org,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Toshi Kani <toshi.kani@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix mpage_writepage() for pages with buffers

On Fri, 6 Oct 2017 14:15:41 -0700 Matthew Wilcox <willy@...radead.org> wrote:

> When using FAT on a block device which supports rw_page, we can hit
> BUG_ON(!PageLocked(page)) in try_to_free_buffers().  This is because we
> call clean_buffers() after unlocking the page we've written.  Introduce a
> new clean_page_buffers() which cleans all buffers associated with a page
> and call it from within bdev_write_page().

This is all pretty mature code (isn't it?).  Any idea why this bug
popped up now?