linux-kernel - Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware authentication optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2017 11:26:24 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Sricharan R <sricharan@...eaurora.org>
Cc:     ohad@...ery.com, robh+dt@...nel.org, mark.rutland@....com,
        andy.gross@...aro.org, david.brown@...aro.org,
        linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org
Subject: Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware
 authentication optional

On Wed 30 Aug 21:45 PDT 2017, Sricharan R wrote:

> qcom_mdt_load function loads the mdt type firmware and
> initialises the secure memory as well. Make the initialisation only
> when requested by the caller, so that the function can be used
> by self-authenticating remoteproc as well.
> 
> Signed-off-by: Sricharan R <sricharan@...eaurora.org>
> ---
>  drivers/soc/qcom/mdt_loader.c       | 70 +++++++++++++++++++++++++++++++------
>  include/linux/soc/qcom/mdt_loader.h |  3 ++
>  2 files changed, 62 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c
> index bd63df0..851f5d7 100644
> --- a/drivers/soc/qcom/mdt_loader.c
> +++ b/drivers/soc/qcom/mdt_loader.c
> @@ -86,9 +86,9 @@ ssize_t qcom_mdt_get_size(const struct firmware *fw)
>   *
>   * Returns 0 on success, negative errno otherwise.
>   */

This kerneldoc is now lacks @pas_init, but as it's just an internal
function and you have kerneldoc on the public functions I suggest that
you drop it.

> -int qcom_mdt_load(struct device *dev, const struct firmware *fw,
> -		  const char *firmware, int pas_id, void *mem_region,
> -		  phys_addr_t mem_phys, size_t mem_size)
> +static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,
> +			   const char *firmware, int pas_id, void *mem_region,
> +			   phys_addr_t mem_phys, size_t mem_size, bool pas_init)

With this you have my Acked-by.

Regards,
Bjorn