linux-kernel - Re: [PATCH 3/3] ARM: mvebu: dts: connect interrupt for WD on armada-38x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2017 20:12:36 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
CC:     "linux@...ck-us.net" <linux@...ck-us.net>,
        "wim@...ana.be" <wim@...ana.be>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/3] ARM: mvebu: dts: connect interrupt for WD on
 armada-38x

On 13/10/17 03:17, Gregory CLEMENT wrote:
> Hi Chris,
>   
>   On mer., oct. 11 2017, Chris Packham <chris.packham@...iedtelesis.co.nz> wrote:
> 
>> The watchdog timer interrupt is available internally on the Armada-38x
>> SoCs. Connect it so that we can have the orion_wdt_irq generate debug
>> information when a watchdog timeout occurs.
> 
> Given the patch 2, when an interrupt is provided by the dt, then the
> behavior of the watchdog changes. So we can't do it for all the
> platform.
> 
> As you propose on your cover letter it is better to set it at board
> level.
> 
> So instead of this patch you should update the binding documentation
> with this new resources. Thanks to this each board developer will be
> able to decide to use this feature or not.

Agreed. I'll drop this patch in favor of a documentation update in v2.

> 
> Thanks,
> 
> Gregory
> 
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>   arch/arm/boot/dts/armada-38x.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
>> index 7ff0811e61db..9ac76c54c9e5 100644
>> --- a/arch/arm/boot/dts/armada-38x.dtsi
>> +++ b/arch/arm/boot/dts/armada-38x.dtsi
>> @@ -408,6 +408,7 @@
>>   				reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>;
>>   				clocks = <&coreclk 2>, <&refclk>;
>>   				clock-names = "nbclk", "fixed";
>> +				interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
>>   			};
>>   
>>   			cpurst: cpurst@...00 {
>> -- 
>> 2.14.2
>>
>