linux-kernel - Re: [PATCH v3 1/2] acpi: apei: remove the unused dead-code for SEA notification type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Oct 2017 16:35:59 +0800
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     Borislav Petkov <bp@...e.de>
CC:     <will.deacon@....com>, <zjzhang@...eaurora.org>,
        <catalin.marinas@....com>, <tbaicar@...eaurora.org>,
        <james.morse@....com>, <geliangtang@...il.com>,
        <andriy.shevchenko@...ux.intel.com>, <tony.luck@...el.com>,
        <austinwc@...eaurora.org>, <rjw@...ysocki.net>, <lenb@...nel.org>,
        <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <john.garry@...wei.com>,
        <shiju.jose@...wei.com>, <zhengqiang10@...wei.com>,
        <wangxiongfeng2@...wei.com>, <huangshaoyu@...wei.com>,
        <wuquanming@...wei.com>
Subject: Re: [PATCH v3 1/2] acpi: apei: remove the unused dead-code for SEA
 notification type

Borislav,
  Thank you for your time to review it.

On 2017/10/13 21:21, Borislav Petkov wrote:
>>  	.notifier_call = ghes_notify_hed,
>>  };
>>  
>> -#ifdef CONFIG_ACPI_APEI_SEA
>>  static LIST_HEAD(ghes_sea);
> But now those get compiled in on x86 where there's no SEA and where we
> don't need them. So no, I don't think this patch is correct.

If have updated the patch for the x86, you can review the version 4 patches.
thanks.