linux-kernel - Re: [PATCH] crypto: ccp: remove unused variable qim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 17:12:12 -0500
From:   Gary R Hook <gary.hook@....com>
To:     Colin King <colin.king@...onical.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: remove unused variable qim

On 10/12/2017 11:55 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable qim is assigned but never read, it is redundant and can
> be removed.
>
> Cleans up clang warning: Value stored to 'qim' is never read
>
> Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Gary R Hook <gary.hook@....com>

> ---
>  drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
> index 65604fc65e8f..44a4d2779b15 100644
> --- a/drivers/crypto/ccp/ccp-dev-v5.c
> +++ b/drivers/crypto/ccp/ccp-dev-v5.c
> @@ -788,13 +788,12 @@ static int ccp5_init(struct ccp_device *ccp)
>  	struct ccp_cmd_queue *cmd_q;
>  	struct dma_pool *dma_pool;
>  	char dma_pool_name[MAX_DMAPOOL_NAME_LEN];
> -	unsigned int qmr, qim, i;
> +	unsigned int qmr, i;
>  	u64 status;
>  	u32 status_lo, status_hi;
>  	int ret;
>
>  	/* Find available queues */
> -	qim = 0;
>  	qmr = ioread32(ccp->io_regs + Q_MASK_REG);
>  	for (i = 0; i < MAX_HW_QUEUES; i++) {
>
>