linux-kernel - Re: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 22:57:37 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        "Shehata, Amir" <amir.shehata@...el.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected
 switch fall-through

On Oct 12, 2017, at 10:16, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

This could also just be "continue;", but doesn't appear harmful.

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lnet/lnet/net_fault.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 03f3d18..7391e16 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -629,6 +629,7 @@ delayed_msg_process(struct list_head *msg_list, bool drop)
> 			case LNET_CREDIT_OK:
> 				lnet_ni_recv(ni, msg->msg_private, msg, 0,
> 					     0, msg->msg_len, msg->msg_len);
> +				/* fall through */
> 			case LNET_CREDIT_WAIT:
> 				continue;
> 			default: /* failures */
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation