linux-kernel - Re: [PATCH] zram: make function zram_page_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 19:15:07 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] zram: make function zram_page_end_io static

(Ccing Andrew, message id: 20171016173336.20320-1-colin.king@...onical.com )

On (10/16/17 18:33), Colin King wrote:
> The function zram_page_end_io is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'zram_page_end_io' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss

> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 88564222f473..d70eba30003a 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -428,7 +428,7 @@ static void put_entry_bdev(struct zram *zram, unsigned long entry)
>  	WARN_ON_ONCE(!was_set);
>  }
>  
> -void zram_page_end_io(struct bio *bio)
> +static void zram_page_end_io(struct bio *bio)
>  {
>  	struct page *page = bio->bi_io_vec[0].bv_page;
>  
> -- 
> 2.14.1
>