linux-kernel - Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 12:24:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, rjw@...ysocki.net, lenb@...nel.org,
        alexander.shishkin@...ux.intel.com, jic23@...nel.org,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        dledford@...hat.com, sean.hefty@...el.com,
        hal.rosenstock@...il.com, hch@....de, sagi@...mberg.me,
        kishon@...com, bhelgaas@...gle.com, nab@...ux-iscsi.org,
        balbi@...nel.org, laurent.pinchart@...asonboard.com,
        jlbec@...lplan.org, ccaulfie@...hat.com, teigland@...hat.com,
        mfasheh@...sity.com, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-usb@...r.kernel.org, cluster-devel@...hat.com,
        ocfs2-devel@....oracle.com, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and
 function arguments const

On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote:
> The ci_type field of the config_item structure do not modify the fields
> of the config_item_type structure it points to. And the other pointers
> initialized with ci_type do not modify the fields as well.
> So, make the ci_type field and the pointers initialized with ci_type
> as const.
> 
> Make the struct config_item_type *type function argument of functions
> config_{item/group}_init_type_name const as the argument in both the
> functions is only stored in the ci_type field of a config_item structure
> which is now made const.
> Make the argument of configfs_register_default_group const as it is
> only passed to the argument of the function config_group_init_type_name
> which is now const.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
> 
>  fs/configfs/dir.c        | 10 +++++-----
>  fs/configfs/item.c       |  6 +++---
>  fs/configfs/symlink.c    |  4 ++--
>  include/linux/configfs.h |  8 ++++----
>  4 files changed, 14 insertions(+), 14 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>