linux-kernel - Re: [PATCH] selftests: add missing test result status in memory-hotplug test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 08:20:26 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     lei.yang@...driver.com, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests: add missing test result status in
 memory-hotplug test

On 10/17/2017 01:06 AM, lei.yang@...driver.com wrote:
> From: Lei Yang <Lei.Yang@...driver.com>
> 
> it only prints FAIL status when test fails, but doesn't print PASS
> status when test pass,this patch is to add PASS status in the test log.
> 
> Signed-off-by: Lei Yang <Lei.Yang@...driver.com>
> ---
>  tools/testing/selftests/memory-hotplug/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
> index afb2624..61d9b04 100644
> --- a/tools/testing/selftests/memory-hotplug/Makefile
> +++ b/tools/testing/selftests/memory-hotplug/Makefile
> @@ -3,10 +3,10 @@ all:
>  include ../lib.mk
>  
>  TEST_PROGS := mem-on-off-test.sh
> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 || echo "selftests: memory-hotplug [FAIL]"
> +override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>  override EMIT_TESTS := echo "$(RUN_TESTS)"
>  
>  run_full_test:
> -	@/bin/bash ./mem-on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
> +	@/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
>  
>  clean:
> 

Looks good to me. I will get this into 4.15-rc1

thanks,
-- Shuah