linux-kernel - Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for hi3660 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 09:31:24 +0800
From:   "Wangtao (Kevin, Kirin)" <kevin.wangtao@...ilicon.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, <edubezval@...il.com>
CC:     <rui.zhang@...el.com>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <sunzhaosheng@...ilicon.com>,
        <gengyanping@...ilicon.com>,
        Kevin Wangtao <kevin.wangtao@...aro.org>
Subject: Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for
 hi3660 SoC



在 2017/10/18 23:54, Daniel Lezcano 写道:
> On 18/10/2017 11:15, Tao Wang wrote:
>> From: Kevin Wangtao <kevin.wangtao@...aro.org>
>>
>> multi alarm interrupt forced a re-trigger of power_allocator_throttle
>> which changes the PID's actual sampling rate, this isn't optimal for
>> IPA, it is best to disable multi alarm support now and sort out this
>> issue later.
>>
>> Signed-off-by: Kevin Wangtao <kevin.wangtao@...aro.org>
> 
> Did you test the series with this change?
Yes
> 
>> ---
>>   drivers/thermal/hisi_thermal.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
>> index 133238a..3b74c12 100644
>> --- a/drivers/thermal/hisi_thermal.c
>> +++ b/drivers/thermal/hisi_thermal.c
>> @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data)
>>   
>>   	/* set interrupt threshold */
>>   	value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]);
>> -	value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10;
>>   	hi3660_thermal_alarm_set(data->regs, sensor->id, value);
>>   
>>   	/* enable interrupt */
>>
> 
>