linux-kernel - Re: [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Oct 2017 17:07:18 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Takashi <tiwai@...e.de>,
        Pierre <pierre-louis.bossart@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>, patches.audio@...el.com,
        alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [PATCH 04/14] soundwire: Add MIPI DisCo property helpers

On Sat, Oct 21, 2017 at 10:20:46AM +0100, Mark Brown wrote:
> On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote:
> 
> > +	/* device is probed so let's read the properties now */
> > +	if (slave->ops && slave->ops->read_prop)
> > +		slave->ops->read_prop(slave);
> 
> Is it valid for us to not be able to read the properties?

Practically no. Without the values bus wont work

> 
> > +		fwnode_property_read_u32(node, "mipi-sdw-port-max-wordlength",
> > +						&dpn[i].max_word);
> > +		fwnode_property_read_u32(node, "mipi-sdw-port-min-wordlength",
> > +						&dpn[i].min_word);
> 
> Don't we know this stuff simply by virtue of knowing what device we're
> talking to (given that there aren't class devices)?

Well I think the spec is midway to device class so they added it to make it
generic :)

-- 
~Vinod