linux-kernel - Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Oct 2017 14:15:11 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Dongjiu Geng <gengdongjiu@...wei.com>
Cc:     rjw@...ysocki.net, lenb@...nel.org, tbaicar@...eaurora.org,
        will.deacon@....com, prarit@...hat.com, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI
 notification type

On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
> 
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
> 
> Cc: Tyler Baicar <tbaicar@...eaurora.org>
> Cc: James Morse <james.morse@....com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@...wei.com>
> Tested-by: Tyler Baicar <tbaicar@...eaurora.org>
> Signed-off-by: Borislav Petkov <bp@...e.de>

I gave you Reviewed-by, not Signed-off-by.

Before you send more patches, read this:

Documentation/process/submitting-patches.rst

You can read the whole document but do especially concentrate on
sections 11-13, in order to get an idea how the SOB chain and all that
patch tagging works.

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--