linux-kernel - Re: [PATCH 1/3] drm/exynos/dsi: Use common error handling code in exynos_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2017 11:08:26 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Cc:     David Airlie <airlied@...ux.ie>, Inki Dae <inki.dae@...sung.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/3] drm/exynos/dsi: Use common error handling code in
 exynos_dsi_enable()

>> @@ -1401,11 +1400,14 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
>>                 dsi->state &= ~DSIM_STATE_ENABLED;
>>                 exynos_dsi_set_display_enable(dsi, false);
>>                 drm_panel_unprepare(dsi->panel);
>> -               pm_runtime_put_sync(dsi->dev);
>> -               return;
>> +               goto put_sync;
>>         }
>>
>>         dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;
>> +       return;
>> +
>> +put_sync:
>> +       pm_runtime_put_sync(dsi->dev);
>>  }
> 
> No, this does not simplify the code.

How do you think about to check a bit more if there are desired effects to consider
when the shown function call is stored only once at the end of this function implementation?


> Stop using coccinelle.

This will not happen for a while. - There are so many source code places left over
where you might care more for similar software improvements.

Regards,
Markus