linux-kernel - Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf open strerror capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2017 20:11:08 -0500
From:   Kim Phillips <kim.phillips@....com>
To:     Will Deacon <will.deacon@....com>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        <linux-arm-kernel@...ts.infradead.org>, <marc.zyngier@....com>,
        <mark.rutland@....com>, <tglx@...utronix.de>,
        <peterz@...radead.org>, <alexander.shishkin@...ux.intel.com>,
        <robh@...nel.org>, <suzuki.poulose@....com>, <pawel.moll@....com>,
        <mathieu.poirier@...aro.org>, <mingo@...hat.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 1/3] perf tool: Introduce arch-specific supplemental perf
 open strerror capability

On Tue, 24 Oct 2017 14:35:35 +0100
Will Deacon <will.deacon@....com> wrote:

> On Tue, Oct 24, 2017 at 03:04:04AM -0500, Kim Phillips wrote:
> > Introduce new tools/perf/arch/*/util/evsel.c:perf_evsel__suppl_strerror()
> > so each arch can start to customize usability for its h/w PMU drivers.
> > 
> > Signed-off-by: Kim Phillips <kim.phillips@....com>
> > ---
> >  tools/perf/arch/x86/util/Build   |  1 +
> >  tools/perf/arch/x86/util/evsel.c | 24 ++++++++++++++++++++++++
> >  tools/perf/util/evsel.c          | 21 +++++++++++++++------
> >  tools/perf/util/evsel.h          |  2 ++
> >  4 files changed, 42 insertions(+), 6 deletions(-)
> >  create mode 100644 tools/perf/arch/x86/util/evsel.c
> 
> This looks sensible to me, although it's difficult to justify all of the
> parameters to perf_evsel__suppl_strerror judging by this patch alone.

I looked at possibly reducing the number of parameters, but since both
evsel and target elements are used to evaluate the condition the error
occurred in, and err, msg, and size are required for basic strerror
functioning, they all look to stay: see the shared strerror function to
see how they're all used.

Thanks,

Kim