linux-kernel - Re: IB/mlx4: Use common error handling code in __mlx4_ib_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Oct 2017 09:39:44 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Dennis Dalessandro <dennis.dalessandro@...el.com>,
        linux-rdma@...r.kernel.org
Cc:     Leon Romanovsky <leon@...nel.org>,
        Doug Ledford <dledford@...hat.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Yuval Shaia <yuval.shaia@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: IB/mlx4: Use common error handling code in
 __mlx4_ib_create_flow()

>> I guess that the shown change possibility can reduce the object code size
>> for the affected function.
…
> You guess?

I am convinced somehow!

> Well perhaps you should find out for certain.

I am trying to point another general implementation detail out:
A jump to an existing call of a function like “mlx4_free_cmd_mailbox”
can be useful if you would like to optimise also this software for
smaller code size.

Are you looking for an information source which you would trust
more (than me)?

> Is it an appreciable impact?

I hope so.

But I showed only the replacement of two function calls here.
I am curious if you care for a small effect at a special place.

A similar refactoring can have a bigger influence in other
software modules, can't it?

There might be an other useful side effect. My concrete proposal
can be questionable as usual.
It seems that the software development attention was increased
a bit so that contributors started thinking about the relevance
of the error code “-EINVAL” at another source code place again.

Regards,
Markus