linux-kernel - Re: [PATCH] selftests: remove obsolete kconfig fragment for cpu-hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Nov 2017 09:46:54 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     lei.yang@...driver.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] selftests: remove obsolete kconfig fragment for
 cpu-hotplug

On Wed, Nov 01, 2017 at 04:14:54PM -0600, Shuah Khan wrote:
> On 10/17/2017 08:10 PM, lei.yang@...driver.com wrote:
> > From: Lei Yang <Lei.Yang@...driver.com>
> > 
> > Kconfig CONFIG_CPU_NOTIFIER_ERROR_INJECT has been removed since kernel 4.10
> > check commit:
> >     commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
> >     Author: Thomas Gleixner <tglx@...utronix.de>
> >     Date:   Wed Dec 21 20:19:53 2016 +0100
> > 
> >         cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions
> > 
> >         hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(),
> >         register_hotcpu_notifier(), register_cpu_notifier(),
> >         __register_hotcpu_notifier(), __register_cpu_notifier(),
> >         unregister_hotcpu_notifier(), unregister_cpu_notifier(),
> >         __unregister_hotcpu_notifier(), __unregister_cpu_notifier()
> >      <snip>
> > 
> > Signed-off-by: Lei Yang <Lei.Yang@...driver.com>
> > ---
> >  tools/testing/selftests/cpu-hotplug/config | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/cpu-hotplug/config b/tools/testing/selftests/cpu-hotplug/config
> > index e6ab090..d4aca2a 100644
> > --- a/tools/testing/selftests/cpu-hotplug/config
> > +++ b/tools/testing/selftests/cpu-hotplug/config
> > @@ -1,2 +1 @@
> >  CONFIG_NOTIFIER_ERROR_INJECTION=y
> > -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
> > 
> 
> Yes. It is removed from the kernel. However, selftests from the latest
> release do get run routinely on older stable releases. Dropping the
> config will impact coverage on older releases.
> 
> Thomas/Greg,
> 
> Any ideas on what we should do about this. On one hand it is a good idea
> to remove it, however my concern is coverage on older releases.

If this is a kernel-internal-api/function test, yeah, just remove it, no
need to keep it around.  The idea of keeping something like this around
wouldn't make much sense.

thanks,

greg k-h