linux-kernel - Re: [PATCH 3.10 112/139] mm: fix overflow check in expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Nov 2017 10:19:43 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Willy Tarreau <w@....eu>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Helge Deller <deller@....de>, Hugh Dickins <hughd@...gle.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3.10 112/139] mm: fix overflow check in expand_upwards()

On Wed, Nov 1, 2017 at 10:26 PM, Willy Tarreau <w@....eu> wrote:
> From: Helge Deller <deller@....de>
>
> commit 37511fb5c91db93d8bd6e3f52f86e5a7ff7cfcdf upstream.
>
> JÃ¶rn Engel noticed that the expand_upwards() function might not return

Jörn (yeah, the original commit suffers from this, too ;-)

> -ENOMEM in case the requested address is (unsigned long)-PAGE_SIZE and
> if the architecture didn't defined TASK_SIZE as multiple of PAGE_SIZE.
>
> Affected architectures are arm, frv, m68k, blackfin, h8300 and xtensa
> which all define TASK_SIZE as 0xffffffff, but since none of those have
> an upwards-growing stack we currently have no actual issue.
>
> Nevertheless let's fix this just in case any of the architectures with
> an upward-growing stack (currently parisc, metag and partly ia64) define
> TASK_SIZE similar.
>
> Link: http://lkml.kernel.org/r/20170702192452.GA11868@p100.box
> Fixes: bd726c90b6b8 ("Allow stack to grow up to address space limit")
> Signed-off-by: Helge Deller <deller@....de>
> Reported-by: Jörn Engel <joern@...estorage.com>
> Cc: Hugh Dickins <hughd@...gle.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Willy Tarreau <w@....eu>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds