linux-kernel - Re: [PATCH] PM / devfreq: Propagate error from devfreq_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 06 Nov 2017 07:41:29 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: Propagate error from devfreq_add_device()

Hi,

On 2017년 11월 04일 12:38, Bjorn Andersson wrote:
> Propagate the error of devfreq_add_device() in devm_devfreq_add_device()
> rather than statically returning ENOMEM. This makes it slightly faster
> to pinpoint the cause of a returned error.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>  drivers/devfreq/devfreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 78fb496ecb4e..99c4021fc33b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -737,7 +737,7 @@ struct devfreq *devm_devfreq_add_device(struct device *dev,
>  	devfreq = devfreq_add_device(dev, profile, governor_name, data);
>  	if (IS_ERR(devfreq)) {
>  		devres_free(ptr);
> -		return ERR_PTR(-ENOMEM);
> +		return devfreq;
>  	}
>  
>  	*ptr = devfreq;
> 

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

But, you better to send this patch to the 'stable@...r.kernel.org'
with the fixes information as following:

Fixes: 8cd84092d35e ("PM / devfreq: Add resource-managed function for devfreq device")
Cc: stable@...r.kernel.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics