lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 5 Nov 2017 10:32:08 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     changbin.du@...el.com
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation
 commands to standalone script


A few spelling fixes:

in the title:

s/Fact out
 /Factor out

* changbin.du@...el.com <changbin.du@...el.com> wrote:

> From: Changbin Du <changbin.du@...el.com>
> 
> The build message for fdimage/isoimage are pretty unstructured. The raw
> shell command blocks are printed. We can improve them as regular build
> system messages. Besides, writing commands in shell script is much more
> easier than in a Makefile.

s/much more easier
 /much more easy

> 
> See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124.
> 
> This patch fact out the commands used for fdimage/isoimage generation from
> arch/x86/boot/Makefile to new script arch/x86/boot/genimage.sh. Then add a
> new kbuild command 'genimage' which invokes the new script. All
> fdimages/isoimage now is generated by call to 'genimage' with different
> parameters.

s/fact out
 /factors out

s/to new script
  to a new script

s/Then add
 /Then it adds

s/a new kbuild command 'genimage'
 /the new 'genimage' kbuild command

s/All fdimages/isoimage now is generated by call to
 /All fdimage/isoimage files are now generated by a call to

> +#   $3 - kernel bzImage file
> +#   $4 - mtool configuration file
> +#   $5 - kernel cmdline
> +#   $6 - inird image file
> +#

The new script is much easier to read!

Thanks,

	Ingo

Powered by blists - more mailing lists