linux-kernel - Re: [PATCH] selftests: add "PASS" status in log for mqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2017 16:37:17 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Lei Yang <Lei.Yang@...driver.com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: add "PASS" status in log for mqueue

On 11/05/2017 02:22 AM, Lei Yang wrote:
> It prints 'FAIL' status when test failed, but not print
> 'PASS' when test passed.
> 
> Signed-off-by: Lei Yang <Lei.Yang@...driver.com>
> ---
>  tools/testing/selftests/mqueue/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
> index 0f5e347..437b048 100644
> --- a/tools/testing/selftests/mqueue/Makefile
> +++ b/tools/testing/selftests/mqueue/Makefile
> @@ -5,12 +5,12 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
>  include ../lib.mk
>  
>  override define RUN_TESTS
> -	$(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
> -	$(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
> +	$(OUTPUT)/mq_open_tests /test1 && echo "selftests: mq_open_tests [PASS]" || echo "selftests: mq_open_tests [FAIL]"
> +	$(OUTPUT)/mq_perf_tests && echo "selftests: mq_perf_tests [PASS]" || echo "selftests: mq_perf_tests [FAIL]"
>  endef
>  
>  override define EMIT_TESTS
> -	echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
> -	echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
> +	echo "./mq_open_tests /test1 && echo \"selftests: mq_open_tests [PASS]\" || echo \"selftests: mq_open_tests [FAIL]\""
> +	echo "./mq_perf_tests && echo \"selftests: mq_perf_tests [PASS]\" || echo \"selftests: mq_perf_tests [FAIL]\""
>  endef
>  
> 
Thanks for the patch. I plan to get this into 4.15-rc1

-- Shuah