linux-kernel - RE: [PATCH 0/2] Account for uncorrectable failures in probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 16:17:06 +0000
From:   <Mario.Limonciello@...l.com>
To:     <pali.rohar@...il.com>
CC:     <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <dvhart@...radead.org>,
        <andy.shevchenko@...il.com>
Subject: RE: [PATCH 0/2] Account for uncorrectable failures in probing

> -----Original Message-----
> From: Limonciello, Mario
> Sent: Friday, November 3, 2017 11:27 AM
> To: dvhart@...radead.org; Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: LKML <linux-kernel@...r.kernel.org>; platform-driver-x86@...r.kernel.org;
> pali.rohar@...il.com; Limonciello, Mario <Mario_Limonciello@...l.com>
> Subject: [PATCH 0/2] Account for uncorrectable failures in probing
> 
> Pali raised some concerns around corner case scenarios that probing
> may fail on dell-wmi-descriptor causing dell-wmi and dell-smbios-wmi
> to be stuck in infinite deferred probing loops.
> 
> This patch series accounts for that corner case.
> 
> Changes since original submission:
> - Add as second patch that catches potential NULL pointer
> - Avoid potential race condition between driver init and calling
>   check for if validation successful
> Mario Limonciello (2):
>   platform/x86: dell-wmi-descriptor: check if memory was allocated
>   platform/x86: dell-*wmi*: Relay failed initial probe to dependent
>     drivers
> 
>  drivers/platform/x86/dell-smbios-wmi.c     |  4 ++++
>  drivers/platform/x86/dell-wmi-descriptor.c | 16 ++++++++++++++++
>  drivers/platform/x86/dell-wmi-descriptor.h |  7 +++++++
>  drivers/platform/x86/dell-wmi.c            |  5 +++++
>  4 files changed, 32 insertions(+)
> 
> --
> 2.14.1

Pali,

Did you have any thoughts on these two patches?  I believe they should 
account for the concerns you raised regarding the corner cases with 
probing in my series.

The series is queued up in the platform-drivers-x86 testing branch and
they are intended to be on top of that.

Thanks,