linux-kernel - Re: [PATCH v2] cpupowerutils: bench

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 11:36:01 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Abhishek <huntbag@...ux.vnet.ibm.com>,
        Shuah Khan <shuah@...nel.org>,
        Thomas Renninger <trenn@...e.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check

On 11/07/2017 02:50 AM, Abhishek wrote:
> Hi,
> 
> Can you please have a look at this also?
> 
> Thanks and Regards,
> Abhishek Goel
> System Engineer
> IBM India Pvt. Ltd.
> 

Same comment on top posting.

> On 11/07/2017 03:17 PM, Abhishek Goel wrote:
>> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
>> this by checking for 1 when the cpu is online.
>>
>> Signed-off-by: Abhishek Goel <huntbag@...ux.vnet.ibm.com>
>> ---
>> v2: Commit message rephrased.
>> ---
>>   tools/power/cpupower/bench/system.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
>> index c25a74a..2bb3eef 100644
>> --- a/tools/power/cpupower/bench/system.c
>> +++ b/tools/power/cpupower/bench/system.c
>> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
>>
>>       dprintf("set %s as cpufreq governor\n", governor);
>>
>> -    if (cpupower_is_cpu_online(cpu) != 0) {
>> +    if (cpupower_is_cpu_online(cpu) != 1) {
>>           perror("cpufreq_cpu_exists");
>>           fprintf(stderr, "error: cpu %u does not exist\n", cpu);
>>           return -1;
> 

Ths patch looks good to me. I still need it in my Inbox. Please send it
to me directly.

thanks,
-- Shuah