linux-kernel - Re: [PATCH 1/3] iommu/vt-d: Missing checks for pasid tables if allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 10:57:24 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     joro@...tes.org, dwmw2@...radead.org,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] iommu/vt-d: Missing checks for pasid tables if
 allocation fails

Hi,

On 11/07/2017 04:13 AM, Alex Williamson wrote:
> On Thu, 19 Oct 2017 08:39:14 +0800
> Lu Baolu <baolu.lu@...ux.intel.com> wrote:
>
>> intel_svm_alloc_pasid_tables() might return an error but never be
>> checked by the callers. Later when intel_svm_bind_mm() is called,
>> there are no checks for valid pasid tables before enabling them.
>>
>> Signed-off-by: Ashok Raj <ashok.raj@...el.com>
>> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
>> ---
>>  drivers/iommu/intel-svm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
>> index f6697e5..43280ca 100644
>> --- a/drivers/iommu/intel-svm.c
>> +++ b/drivers/iommu/intel-svm.c
>> @@ -292,7 +292,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
>>  	int pasid_max;
>>  	int ret;
>>  
>> -	if (WARN_ON(!iommu))
>> +	if (WARN_ON(!iommu || !iommu->pasid_table))
>>  		return -EINVAL;
>>  
>>  	if (dev_is_pci(dev)) {
> Applied series to iommu/vt-d for v4.15.  Thanks,
>
> Alex
>

Thank you, Alex.

Best regards,
Lu Baolu