linux-kernel - Re: [PATCH v2 1/4] x86, build: Factor out fdimage/isoimage generation commands to standalone script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 11:20:29 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     changbin.du@...el.com
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH v2 1/4] x86, build: Factor out fdimage/isoimage
 generation commands to standalone script


* changbin.du@...el.com <changbin.du@...el.com> wrote:

> From: Changbin Du <changbin.du@...el.com>
> 
> The build message for fdimage/isoimage are pretty unstructured. The raw
> shell command blocks are printed. We can improve them as regular build
> system messages. Besides, writing commands in a shell script is much more
> easy than in a Makefile.
> 
> See Ingo's suggestion here https://lkml.org/lkml/2017/10/31/124.
> 
> This patch factors out the commands used for fdimage/isoimage generation
> from arch/x86/boot/Makefile to a new script arch/x86/boot/genimage.sh.
> Then it adds the new kbuild command 'genimage' which invokes the new script.
> All fdimages/isoimage files are now generated by a call to 'genimage' with
> different parameters.
> 
> Now 'make isoimage' becomes:
> ...
> Kernel: arch/x86/boot/bzImage is ready  (#30)
>   GENIMAGE arch/x86/boot/image.iso
> Size of boot image is 4 sectors -> No emulation
>  15.37% done, estimate finish Sun Nov  5 23:36:57 2017
>  30.68% done, estimate finish Sun Nov  5 23:36:57 2017
>  46.04% done, estimate finish Sun Nov  5 23:36:57 2017
>  61.35% done, estimate finish Sun Nov  5 23:36:57 2017
>  76.69% done, estimate finish Sun Nov  5 23:36:57 2017
>  92.00% done, estimate finish Sun Nov  5 23:36:57 2017
> Total translation table size: 2048
> Total rockridge attributes bytes: 659
> Total directory bytes: 0
> Path table size(bytes): 10
> Max brk space used 0
> 32608 extents written (63 MB)
> Kernel: arch/x86/boot/image.iso is ready

Could we please also do another patch, to make it emit only this by default:

>   GENIMAGE arch/x86/boot/image.iso

None of the other messages really matter to the user.

Maybe emit them when building with V=1 - but none of that info is really 
interesting IMHO.

Thanks,

	Ingo