linux-kernel - Re: Sony-laptop: Adjustments for sony_nc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 14:49:48 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Marco Chiappero <marco@...ence.it>,
        Matthew Garrett <mjg@...hat.com>,
        Mattia Dongili <malattia@...ux.it>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: Sony-laptop: Adjustments for sony_nc_setup_rfkill()

On Sun, Nov 5, 2017 at 4:20 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
>>> Do you find the following details useful for further clarification?
>>>
>>> text: -32
>>> data: 0
>>> bss:  0

...

>> So, the main question is "WHY" you are doing this change.
>>
>> I didn't find any convinced explanation (yet?).
>
> Do you find a reduction of 32 bytes for the object code not interesting
> enough just by achieving such a small effect because of the replacement
> of three function calls “rfkill_destroy” with goto statements?

Okay, it's something.

Update a commit message in your patch, use bloat-o-meter (and put its
output to the commit message) and resend, we might reconsider then.

-- 
With Best Regards,
Andy Shevchenko