linux-kernel - Re: [PATCH] Documentation/rs485: Fix missing zero init on sample code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 17:09:14 +0100
From:   Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, claudio@...dence.eu.com
Subject: Re: [PATCH] Documentation/rs485: Fix missing zero init on sample code

Hi Jiri

On Tue, Nov 7, 2017 at 2:28 PM, Jiri Slaby <jslaby@...e.cz> wrote:
> On 11/06/2017, 11:51 AM, Ricardo Ribalda Delgado wrote:
>> The sample code does not initialize to zero a local variable and then it
>> uses the uninitialized code.
>>
>> Fix in case someone copy/paste the sample code.
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>> ---
>>  Documentation/serial/serial-rs485.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/serial/serial-rs485.txt b/Documentation/serial/serial-rs485.txt
>> index 389fcd4759e9..2bbae93bf279 100644
>> --- a/Documentation/serial/serial-rs485.txt
>> +++ b/Documentation/serial/serial-rs485.txt
>> @@ -54,7 +54,7 @@
>>               /* Error handling. See errno. */
>>       }
>>
>> -     struct serial_rs485 rs485conf;
>> +     struct serial_rs485 rs485conf = {};
>
> I think that TIOCGRS485 is missing here instead. Ccing the author of the
> text.
>
That will also do.



> Does it break classifying potatoes :)?

The potato machine has to speak to other industrial machines :).

Hey!: I am running of potatoes!, Need another truck.

>
>>       /* Enable RS485 mode: */
>>       rs485conf.flags |= SER_RS485_ENABLED;
>>
>
> thanks,
> --
> js
> suse labs



-- 
Ricardo Ribalda