linux-kernel - Re: Re: [PATCH] Fix: Removed warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 9 Nov 2017 10:06:54 -0800
From:   Kees Cook <keescook@...omium.org>
To:     mail@...l.no
Cc:     "Luis R. Rodriguez" <mcgrof@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] Fix: Removed warning.

On Wed, Nov 8, 2017 at 11:12 PM,  <mail@...l.no> wrote:
> Oh, yes, guess I missed that, neither the 0-return nor the kfree()-call
> needs to be in the if block. As for the whitespace issues, I will attempt to
> setup git-send-email later today.
>
> Should I apply what you suggested, generate a new patch, and submit again?

Yes please. :) And for your v2, also add Andrew Morton
<akpm@...ux-foundation.org> on Cc (most sysctl changes go through his
tree with myself and Luis "Ack"ing them).

> (First time submitting a patch, so the process is all new to me)

Welcome to the project! :)

Thanks!

-Kees

-- 
Kees Cook
Pixel Security