linux-kernel - Re: [PATCH] infiniband: avoid uninitialized variable warning in create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 11:21:05 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Doug Ledford <dledford@...hat.com>, Christoph Hellwig <hch@....de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Matan Barak <matanb@...lanox.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Dasaratharaman Chandramouli 
        <dasaratharaman.chandramouli@...el.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: avoid uninitialized variable warning in
 create_udata

On Fri, Nov 10, 2017 at 11:10:31PM +0100, Arnd Bergmann wrote:
> As Dan pointed out, the rework I did makes it harder for smatch and other
> static checkers to figure out what is going on with the uninitialized
> pointers.
>
> By open-coding the call in create_udata(), we make it more readable for
> both humans and tools.
>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Fixes: 12f727721eee ("IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/infiniband/core/uverbs_std_types.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)