linux-kernel - Re: [PATCH] qlge: remove duplicated assignment to mbcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 19:13:54 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     harish.patil@...ium.com, manish.chopra@...ium.com,
        Dept-GELinuxNICDev@...ium.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qlge: remove duplicated assignment to mbcp

From: Colin King <colin.king@...onical.com>
Date: Thu,  9 Nov 2017 07:52:15 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> The assignment to mbcp is identical to the initiatialized value assigned
> to mbcp at declaration time a few lines earlier, hence we can remove the
> second redundant assignment.  Cleans up clang warning:
> 
> drivers/net/ethernet/qlogic/qlge/qlge_mpi.c:209:22: warning:
> Value stored to 'mbcp' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.