linux-kernel - Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Nov 2017 22:16:33 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Arnd Bergmann <arnd@...db.de>
cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Sudeep Holla <sudeep.holla@....com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as
 __init

On Mon, 6 Nov 2017, Arnd Bergmann wrote:
> The newly added function triggers a harmless Kbuild warning because
> of a missing annotation:
> 
> WARNING: vmlinux.o(.text+0x448098): Section mismatch in reference from the function timer_of_exit() to the function .init.text:timer_clk_exit()
> The function timer_of_exit() references
> the function __init timer_clk_exit().
> This is often because timer_of_exit lacks a __init
> annotation or the annotation of timer_clk_exit is wrong.
> 
> The function is only called from other __init functions, so it
> can safely be marked as __init as well.

Hmm. I don't see any caller at all. From the intention of the patch I
assume this isn't designed for using from init functions, so we rather have
to remove the __init annotations from the called functions.

Sudeep posted a patch which does that:

 https://lkml.kernel.org/r/1509979716-10646-1-git-send-email-sudeep.holla@arm.com

Though I rather would know whether this function is going to be used at
all and what the intention of this patch was.

Benjamin????

Thanks,

	tglx