lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 12 Nov 2017 16:03:15 -0800 From: Stephen Hemminger <stephen@...workplumber.org> To: Rasmus Villemoes <linux@...musvillemoes.dk> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/7] net: core: maybe return -EEXIST in __dev_alloc_name On Mon, 13 Nov 2017 00:15:09 +0100 Rasmus Villemoes <linux@...musvillemoes.dk> wrote: > If we're given format string with no %d, -EEXIST is a saner error code. > > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk> > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index c0a92cf27566..7c08b4ca7b76 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1104,7 +1104,7 @@ static int __dev_alloc_name(struct net *net, const char *name, char *buf) > * when the name is long and there isn't enough space left > * for the digits, or if all bits are used. > */ > - return -ENFILE; > + return p ? -ENFILE : -EEXIST; > } > > static int dev_alloc_name_ns(struct net *net, This is potentially a change to user ABI with no real advantage.
Powered by blists - more mailing lists