linux-kernel - Re: [PATCH 3/3] backlight: tps65217

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Nov 2017 13:55:25 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Johan Hovold <johan@...nel.org>, Lee Jones <lee.jones@...aro.org>
Cc:     Jingoo Han <jingoohan1@...il.com>, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable <stable@...r.kernel.org>,
        Matthias Kaehlcke <matthias@...hlcke.net>
Subject: Re: [PATCH 3/3] backlight: tps65217_bl: fix device-tree node lookup

On 13/11/17 10:20, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
> 
> This would only cause trouble if the child node is missing while there
> is an unrelated node named "backlight" elsewhere in the tree.
> 
> Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
> Cc: stable <stable@...r.kernel.org>     # 3.7
> Cc: Matthias Kaehlcke <matthias@...hlcke.net>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Acked-by: Daniel Thompson <daniel.thompson@...aro.org>


> ---
>   drivers/video/backlight/tps65217_bl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c
> index 380917c86276..762e3feed097 100644
> --- a/drivers/video/backlight/tps65217_bl.c
> +++ b/drivers/video/backlight/tps65217_bl.c
> @@ -184,11 +184,11 @@ static struct tps65217_bl_pdata *
>   tps65217_bl_parse_dt(struct platform_device *pdev)
>   {
>   	struct tps65217 *tps = dev_get_drvdata(pdev->dev.parent);
> -	struct device_node *node = of_node_get(tps->dev->of_node);
> +	struct device_node *node;
>   	struct tps65217_bl_pdata *pdata, *err;
>   	u32 val;
>   
> -	node = of_find_node_by_name(node, "backlight");
> +	node = of_get_child_by_name(tps->dev->of_node, "backlight");
>   	if (!node)
>   		return ERR_PTR(-ENODEV);
>   
>