linux-kernel - Re: lockdep annotation for desc->request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Nov 2017 15:11:45 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andrew Lunn <andrew@...n.ch>
cc:     Lucas Stach <l.stach@...gutronix.de>,
        Chris Healy <cphealy@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: lockdep annotation for desc->request_mutex

Andrew,

On Thu, 9 Nov 2017, Andrew Lunn wrote:

> Hi Thomas
> 
> I'm been given reports of a new lockdep splat while testing
> 4.14-rc8. It appears to be a false positive, due to missing lockdep
> annotation on desc->request_mutex. The driver is using two different
> interrupt descriptors via different paths. But without annotation,
> lockdep thinks it is the same mutex.

Hmm.

> Do you have patches adding a lockdep class for desc->request_mutex?

No. I think we should extend irq_set_lockdep_class() and hand in two keys
then.

Thanks,

	tglx