linux-kernel - Re: [PATCH] mailbox/omap: unregister mbox class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Nov 2017 10:28:30 -0600
From:   Suman Anna <s-anna@...com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        <jassisinghbrar@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] mailbox/omap: unregister mbox class

On 11/11/2017 12:09 PM, Arvind Yadav wrote:
> platform_driver_register() can fail here and we must unregister mbox
> class.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Acked-by: Suman Anna <s-anna@...com>

regards
Suman

> ---
>  drivers/mailbox/omap-mailbox.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index c5e8b9c..2517038 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -906,7 +906,11 @@ static int __init omap_mbox_init(void)
>  	mbox_kfifo_size = max_t(unsigned int, mbox_kfifo_size,
>  							sizeof(mbox_msg_t));
>  
> -	return platform_driver_register(&omap_mbox_driver);
> +	err = platform_driver_register(&omap_mbox_driver);
> +	if (err)
> +		class_unregister(&omap_mbox_class);
> +
> +	return err;
>  }
>  subsys_initcall(omap_mbox_init);
>  
>