linux-kernel - Re: [PATCH 2/7] perf tests: Set evlist of test__backward_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Nov 2017 15:30:57 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wang Nan <wangnan0@...wei.com>
Cc:     linux-kernel@...r.kernel.org, kan.liang@...el.com,
        jolsa@...hat.com, namhyung@...nel.org
Subject: Re: [PATCH 2/7] perf tests: Set evlist of
 test__backward_ring_buffer() to !overwrite

Em Mon, Nov 13, 2017 at 01:38:04AM +0000, Wang Nan escreveu:
> Setting overwrite in perf_evlist__mmap() is meaningless because the
> event in this evlist is already have 'overwrite' postfix and goes to
> backward ring buffer automatically. Pass 'false' to perf_evlist__mmap()
> to make it similar to others.

applied
 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> ---
>  tools/perf/tests/backward-ring-buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/backward-ring-buffer.c b/tools/perf/tests/backward-ring-buffer.c
> index d233ad3..992c917 100644
> --- a/tools/perf/tests/backward-ring-buffer.c
> +++ b/tools/perf/tests/backward-ring-buffer.c
> @@ -58,7 +58,7 @@ static int do_test(struct perf_evlist *evlist, int mmap_pages,
>  	int err;
>  	char sbuf[STRERR_BUFSIZE];
>  
> -	err = perf_evlist__mmap(evlist, mmap_pages, true);
> +	err = perf_evlist__mmap(evlist, mmap_pages, false);
>  	if (err < 0) {
>  		pr_debug("perf_evlist__mmap: %s\n",
>  			 str_error_r(errno, sbuf, sizeof(sbuf)));
> -- 
> 2.10.1