linux-kernel - Re: [PATCH] kbuild: move coccicheck help in scripts/Makefile.help to top Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2017 10:54:44 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     linux-kbuild@...r.kernel.org, cocci@...teme.lip6.fr,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: move coccicheck help in scripts/Makefile.help
 to top Makefile



On Tue, 14 Nov 2017, Masahiro Yamada wrote:

> I do not think it is helpful to have a separate file just for the
> coccicheck help message.  Merge scripts/Makefile.help into the
> top-level Makefile.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

Thanks!

> ---
>
>  Makefile              | 2 +-
>  scripts/Makefile.help | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
>  delete mode 100644 scripts/Makefile.help
>
> diff --git a/Makefile b/Makefile
> index f060f94..3b7d477 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1388,7 +1388,7 @@ help:
>  	@echo  '  export_report   - List the usages of all exported symbols'
>  	@echo  '  headers_check   - Sanity check on exported headers'
>  	@echo  '  headerdep       - Detect inclusion cycles in headers'
> -	@$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
> +	@echo  '  coccicheck      - Check with Coccinelle'
>  	@echo  ''
>  	@echo  'Kernel selftest:'
>  	@echo  '  kselftest       - Build and run kernel selftest (run as root)'
> diff --git a/scripts/Makefile.help b/scripts/Makefile.help
> deleted file mode 100644
> index d03608f..0000000
> --- a/scripts/Makefile.help
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -
> -checker-help:
> -	@echo  '  coccicheck      - Check with Coccinelle.'
> --
> 2.7.4
>
>