linux-kernel - [tip:irq/urgent] irqchip/exiu: Fix return value check in exiu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2017 02:30:41 -0800
From:   tip-bot for Wei Yongjun <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, weiyongjun1@...wei.com, tglx@...utronix.de,
        hpa@...or.com, marc.zyngier@....com, linux-kernel@...r.kernel.org,
        jason@...edaemon.net, ard.biesheuvel@...aro.org
Subject: [tip:irq/urgent] irqchip/exiu: Fix return value check in
 exiu_init()

Commit-ID:  0e54705b0e01dcaf3eb2a496bb66d5f05012056b
Gitweb:     https://git.kernel.org/tip/0e54705b0e01dcaf3eb2a496bb66d5f05012056b
Author:     Wei Yongjun <weiyongjun1@...wei.com>
AuthorDate: Tue, 14 Nov 2017 06:57:28 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Tue, 14 Nov 2017 11:27:22 +0100

irqchip/exiu: Fix return value check in exiu_init()

In case of error, the function of_iomap() returns NULL pointer not
ERR_PTR().

Replace the IS_ERR() test of the return value with NULL test and return
a proper error code.

Fixes: 706cffc1b912 ("irqchip/exiu: Add support for Socionext Synquacer EXIU controller")
Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Marc Zyngier <marc.zyngier@....com>
Cc: Jason Cooper <jason@...edaemon.net>
Link: https://lkml.kernel.org/r/1510642648-123574-1-git-send-email-weiyongjun1@huawei.com

---
 drivers/irqchip/irq-sni-exiu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
index 1b6e2f7..1927b2f 100644
--- a/drivers/irqchip/irq-sni-exiu.c
+++ b/drivers/irqchip/irq-sni-exiu.c
@@ -196,8 +196,8 @@ static int __init exiu_init(struct device_node *node,
 	}
 
 	data->base = of_iomap(node, 0);
-	if (IS_ERR(data->base)) {
-		err = PTR_ERR(data->base);
+	if (!data->base) {
+		err = -ENODEV;
 		goto out_free;
 	}