linux-kernel - Re: [PATCH 7/9] fix get_timespec64() for y2038 safe compat interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2017 15:17:17 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        John Stultz <john.stultz@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>
Subject: Re: [PATCH 7/9] fix get_timespec64() for y2038 safe compat interfaces

On Fri, Nov 10, 2017 at 11:42 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote:

> +
> +       /* Zero out the padding for 32 bit systems or in compat mode */
> +       if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall())
> +               kts.tv_nsec &= 0xFFFFFFFFUL;

Is this correct for x32? Since x32 has a 64-bit tv_nsec, I think we currently
return an error in timespec64_valid when e.g. you pass 0xffffffff00000000
as the tv_nsec value, while after this patch x32 would behave the same way
as other 32-bit architectures and silently clear the upper bits.

      Arnd