Date:   Tue, 14 Nov 2017 13:54:59 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Jeremy Cline <jeremy@...ine.org>
Cc:     alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.com>,
        linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [alsa-devel] [PATCH v3] ASoC: Replace snd_soc_acpi_check_hid with
 acpi_dev_present



On 11/14/2017 01:12 PM, Jeremy Cline wrote:
> On Mon, Nov 13, 2017 at 01:43:57PM -0600, Pierre-Louis Bossart wrote:
>> On 11/10/2017 12:36 PM, Jeremy Cline wrote:
>>> Replace snd_soc_acpi_check_hid() with the generic acpi_dev_present()
>>> and remove the now unused snd_soc_acpi_check_hid function. This should
>>> have no functional change.
>> The code looks ok, but I'd like to first add the fix for the quirk handling
>> regression which appeared in 4.13 and is still there in 4.14. Current fix is
>> at https://bugzilla.kernel.org/attachment.cgi?id=258581
>>
>> Can we wait a couple of days on this one to avoid mixing bug fixes and
>> renames? this would also make the stable branch fix easier to handle.
> That makes perfect sense to me. I'm pretty new to all this, should I just
> keep an eye on things and rebase this once that patch lands?
if it's easier I can submit both the fix and your change in the same 
series (keeping you as the author of course)
>
> Thanks,
> Jeremy
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Powered by blists - more mailing lists