linux-kernel - Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Nov 2017 14:55:19 -0800
From:   Joe Perches <joe@...ches.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jiri Kosina <jikos@...nel.org>
Cc:     Song Liu <songliubraving@...com>, linux-kernel@...r.kernel.org,
        kernel-team@...com, trivial@...nel.org
Subject: Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

On Wed, 2017-11-15 at 13:14 -0500, Steven Rostedt wrote:
> On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu <mhiramat@...nel.org> wrote:
> > On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu <songliubraving@...com> wrote:
> > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of
> > > "trace_kprobe".  
> > Oh, good catch!
> > Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> Thanks.
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Jiri, can you take this in your tree?
> 
[]
> > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
[]
> > > @@ -17,7 +17,7 @@
> > >   * Copyright (C) IBM Corporation, 2010-2012
> > >   * Author:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> > >   */
> > > -#define pr_fmt(fmt)	"trace_kprobe: " fmt
> > > +#define pr_fmt(fmt)	"trace_uprobe: " fmt

Maybe use the much more common below instead?

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt