linux-kernel - Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Nov 2017 17:24:05 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        USB <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

On 11/15/2017 05:01 PM, Badhri Jagan Sridharan wrote:
> On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck <linux@...ck-us.net> wrote:
[ ... ]
>>
>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>>
>> /* Though I really dislike this new-world comment style.
>>   * It hurts my eyes and distracts me from the code.
>>   */
> 
> Did I somehow introduce this ? I dont think I introduced new comments.
> 

[ ... ]

>>> +                                     /* There could only be one fixed pdo
>>> +                                      * at a specific voltage level.
>>> +                                      * So breaking here.
>>> +                                      */

Guenter