linux-kernel - Re: [PATCH] input: remove unneeded DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Nov 2017 11:27:24 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        linux-kernel@...r.kernel.org,
        Philippe Ombredanne <pombredanne@...b.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

On Fri, Nov 17, 2017 at 12:33:13PM -0800, Dmitry Torokhov wrote:
> On Fri, Nov 17, 2017 at 03:17:20PM +0100, Greg Kroah-Hartman wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> > 
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference.  For some of these drivers, the #define is just a
> > few lines above the MODULE_LICENSE() line, which is extra pointless.
> > 
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Cc: Arvind Yadav <arvind.yadav.cs@...il.com>
> > Reported-by: Philippe Ombredanne <pombredanne@...b.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/input/misc/keyspan_remote.c | 3 +--
> >  drivers/input/tablet/acecad.c       | 3 +--
> >  drivers/input/tablet/hanwang.c      | 3 +--
> >  drivers/input/tablet/kbtab.c        | 3 +--
> >  4 files changed, 4 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/input/misc/keyspan_remote.c b/drivers/input/misc/keyspan_remote.c
> > index 77c47d6325fe..4f13b2f7bf4f 100644
> > --- a/drivers/input/misc/keyspan_remote.c
> > +++ b/drivers/input/misc/keyspan_remote.c
> > @@ -20,7 +20,6 @@
> >  #define DRIVER_VERSION	"v0.1"
> >  #define DRIVER_AUTHOR	"Michael Downey <downey@...eta.com>"
> >  #define DRIVER_DESC	"Driver for the USB Keyspan remote control."
> > -#define DRIVER_LICENSE	"GPL"
> 
> If we do this, can we also get rid of other DIRVER_* macros that are not
> useful?

Please do, I got rid of all of the DRIVER_VERSION crap in the
drivers/usb/ tree a release or so ago, as they make no sense at all.
The other defines are also really silly and can be cleaned up too.

Want me to do that for drivers/input/ for you?

thanks,

greg "I'm a janitor now" k-h