linux-kernel - Re: [PATCH] iio: cros_ec: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Nov 2017 10:32:51 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Paolo Cretaro <paolocretaro@...il.com>
Cc:     knaack.h@....de, lars@...afoo.de, gwendal@...omium.org,
        enric.balletbo@...labora.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: cros_ec: Remove unused variables

On Sun, 19 Nov 2017 01:57:45 +0100
Paolo Cretaro <paolocretaro@...il.com> wrote:

> Fix gcc warnings about variable 'ec_device' being set but not used
> in these files:
> common/cros_ec_sensors/cros_ec_sensors.c:194:25
> light/cros_ec_light_prox.c:184:25
> 
> Signed-off-by: Paolo Cretaro <paolocretaro@...il.com>

Applied to the togreg branch of iio.git and pushed out as testing 
(at some point soonish) for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 --
>  drivers/iio/light/cros_ec_light_prox.c               | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> index ed8063f2da99..7d30c59da3e2 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c
> @@ -191,7 +191,6 @@ static int cros_ec_sensors_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
> -	struct cros_ec_device *ec_device;
>  	struct iio_dev *indio_dev;
>  	struct cros_ec_sensors_state *state;
>  	struct iio_chan_spec *channel;
> @@ -201,7 +200,6 @@ static int cros_ec_sensors_probe(struct platform_device *pdev)
>  		dev_warn(&pdev->dev, "No CROS EC device found.\n");
>  		return -EINVAL;
>  	}
> -	ec_device = ec_dev->ec_dev;
>  
>  	indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*state));
>  	if (!indio_dev)
> diff --git a/drivers/iio/light/cros_ec_light_prox.c b/drivers/iio/light/cros_ec_light_prox.c
> index b2a46b390d5c..acfad4aeb27a 100644
> --- a/drivers/iio/light/cros_ec_light_prox.c
> +++ b/drivers/iio/light/cros_ec_light_prox.c
> @@ -181,7 +181,6 @@ static int cros_ec_light_prox_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct cros_ec_dev *ec_dev = dev_get_drvdata(dev->parent);
> -	struct cros_ec_device *ec_device;
>  	struct iio_dev *indio_dev;
>  	struct cros_ec_light_prox_state *state;
>  	struct iio_chan_spec *channel;
> @@ -191,7 +190,6 @@ static int cros_ec_light_prox_probe(struct platform_device *pdev)
>  		dev_warn(dev, "No CROS EC device found.\n");
>  		return -EINVAL;
>  	}
> -	ec_device = ec_dev->ec_dev;
>  
>  	indio_dev = devm_iio_device_alloc(dev, sizeof(*state));
>  	if (!indio_dev)